[webkit-reviews] review granted: [Bug 197405] [JSC] Inlining Getter/Setter should care availability of ad-hocly constructed frame : [Attachment 368644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 30 19:57:13 PDT 2019


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 197405: [JSC] Inlining Getter/Setter should care availability of ad-hocly
constructed frame
https://bugs.webkit.org/show_bug.cgi?id=197405

Attachment 368644: Patch

https://bugs.webkit.org/attachment.cgi?id=368644&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 368644
  --> https://bugs.webkit.org/attachment.cgi?id=368644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368644&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1694
> +		   VirtualRegister argumentToSet =
callerStackTop->remapOperand(virtualRegisterForArgument(index,
registerOffsetAfterFixup));

nit: as we spoke about on IRC, we think this can be:
m_inlineStackTop->remapOperand(virtualRegisterForArgument(index))


More information about the webkit-reviews mailing list