[webkit-reviews] review granted: [Bug 197332] Add logging of Ad Click Attribution errors and events to a dedicated channel : [Attachment 368589] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 197332: Add logging of Ad Click Attribution errors and events to a
dedicated channel
https://bugs.webkit.org/show_bug.cgi?id=197332

Attachment 368589: Patch

https://bugs.webkit.org/attachment.cgi?id=368589&action=review




--- Comment #31 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 368589
  --> https://bugs.webkit.org/attachment.cgi?id=368589
Patch

I would tend for now to not log the URLs since in most cases except
clearExpired, there is an ongoing load that a web developer can see that should
relate to the ad clicks.

View in context: https://bugs.webkit.org/attachment.cgi?id=368589&action=review

> Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:95
> +    auto& conversionPriority = conversion.priority;

Why not inlining these in below RELEASE_LOG_INFO_IF.