[webkit-reviews] review granted: [Bug 197399] Protect against null crash in fetchDiskCacheEntries : [Attachment 368537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 30 14:26:13 PDT 2019

Antti Koivisto <koivisto at iki.fi> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197399: Protect against null crash in fetchDiskCacheEntries

Attachment 368537: Patch


--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 368537
  --> https://bugs.webkit.org/attachment.cgi?id=368537

View in context: https://bugs.webkit.org/attachment.cgi?id=368537&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1277
> +	       case NetworkCache::Cache::TraversalResult::DecodeError:

This shouldn't assert. The design is to handle serialization format changes
(and corruption for any reason) silently.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1461
> +	       ASSERT_NOT_REACHED();

Same here.

More information about the webkit-reviews mailing list