[webkit-reviews] review granted: [Bug 197296] Web Inspector: DOM: rename "low power" to "display composted" : [Attachment 368277] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 197296: Web Inspector: DOM: rename "low power" to "display composted"
https://bugs.webkit.org/show_bug.cgi?id=197296

Attachment 368277: Patch

https://bugs.webkit.org/attachment.cgi?id=368277&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 368277
  --> https://bugs.webkit.org/attachment.cgi?id=368277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review

rs=me but I think there could be a better name for it still

> Source/JavaScriptCore/ChangeLog:3
> +	   Web Inspector: DOM: rename "low power" to "display composted"

Typo in all ChangeLogs from the bug title: "composted" => "composited"

>
Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2
> +<?xml version="1.0" encoding="utf-8"?>
> +<!-- Copyright © 2013 Apple Inc. All rights reserved. -->

This year should probably be 2010 instead of 2013. I see it is changing from an
[L] to a [D].

> Source/WebInspectorUI/UserInterface/Models/MediaTimelineRecord.js:90
> +	   if (this._eventType ===
WI.MediaTimelineRecord.EventType.DisplayCompositedStateChanged)
> +	       return this._isDisplayComposited ? WI.UIString("Started Display
Compositing") : WI.UIString("Stopped Display Compositing");

This name sounds confusing to me. What is "Display Compositing"? I like the
idea of "Started/Stopped Efficient Video Rendering" or something specific to
the video compositing display.