[webkit-reviews] review granted: [Bug 197347] [iOS]Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event) : [Attachment 368475] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 197347: [iOS]Double-tapping a post to like doesn't work on Instagram.com
(needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347

Attachment 368475: Patch

https://bugs.webkit.org/attachment.cgi?id=368475&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 368475
  --> https://bugs.webkit.org/attachment.cgi?id=368475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368475&action=review

> Source/WebCore/page/ios/FrameIOS.mm:427
> +	   auto node = hitTestResult.innerNode();

Nit - auto*?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:734
> +    auto shiftKey = modifiers.contains(WebEvent::Modifier::ShiftKey);

Nit - I *think* we prefer bool over auto in cases like this 🤷🏻‍♂️

> LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html:51
> +	    setTimeout("testRunner.notifyDone()", 0);

Nit - it looks like there's a tab character somewhere here.

> LayoutTests/fast/events/touch/ios/double-tap-for-double-click3.html:50
> +	setTimeout("testRunner.notifyDone()", 0);

Nit - another tab.