[webkit-reviews] review granted: [Bug 186732] JITStubRoutineSet wastes 180KB of HashTable capacity on can.com : [Attachment 368443] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 186732: JITStubRoutineSet wastes 180KB of HashTable capacity on can.com
https://bugs.webkit.org/show_bug.cgi?id=186732

Attachment 368443: Patch

https://bugs.webkit.org/attachment.cgi?id=368443&action=review




--- Comment #30 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 368443
  --> https://bugs.webkit.org/attachment.cgi?id=368443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368443&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   Our current mechanism of JITStubRoutineSet is too memory consuming.
Basically we have HashMap<uintptr_t, StubRoutine*> and register

"is too memory consuming" => "consumes more memory than needed".

> Source/JavaScriptCore/ChangeLog:10
> +	   In Gmail, we see ~2MB table size.

"see" => "see a"