[webkit-reviews] review requested: [Bug 186732] JITStubRoutineSet wastes 180KB of HashTable capacity on can.com : [Attachment 368422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 28 22:51:33 PDT 2019
Yusuke Suzuki <ysuzuki at apple.com> has asked for review:
Bug 186732: JITStubRoutineSet wastes 180KB of HashTable capacity on can.com
https://bugs.webkit.org/show_bug.cgi?id=186732
Attachment 368422: Patch
https://bugs.webkit.org/attachment.cgi?id=368422&action=review
--- Comment #27 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 368422
--> https://bugs.webkit.org/attachment.cgi?id=368422
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=368422&action=review
>> Source/JavaScriptCore/heap/JITStubRoutineSet.cpp:99
>> + routine.routine->m_mayBeExecuting = true;
>
> I think we should track this information only when,
>
> 1. stub requires marking
> 2. stub is jettisoned
>
> We could make the size of array small I think. I'll do that.
For now, I'll start with this simple patch.
More information about the webkit-reviews
mailing list