[webkit-reviews] review requested: [Bug 197319] [ews-build] Do not print worker environment variables in each build step : [Attachment 368335] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 26 11:59:54 PDT 2019


Dean Johnson <dean_johnson at apple.com> has asked  for review:
Bug 197319: [ews-build] Do not print worker environment variables in each build
step
https://bugs.webkit.org/show_bug.cgi?id=197319

Attachment 368335: Patch

https://bugs.webkit.org/attachment.cgi?id=368335&action=review




--- Comment #4 from Dean Johnson <dean_johnson at apple.com> ---
Comment on attachment 368335
  --> https://bugs.webkit.org/attachment.cgi?id=368335
Patch

Maybe it'd be worth setting logEnviron=False in a new base class that inherited
from shell.ShellCommand? Such as:

class MinimalLoggingShellCommand(shell.ShellCommand):
    logEnviron = False


More information about the webkit-reviews mailing list