[webkit-reviews] review granted: [Bug 197275] [iOS] Add internal setting to force -webkit-text-size-adjust to "auto" : [Attachment 368276] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 197275: [iOS] Add internal setting to force -webkit-text-size-adjust to
"auto"
https://bugs.webkit.org/show_bug.cgi?id=197275

Attachment 368276: Patch

https://bugs.webkit.org/attachment.cgi?id=368276&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 368276
  --> https://bugs.webkit.org/attachment.cgi?id=368276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368276&action=review

> Source/WebKit/Shared/WebPreferences.yaml:450
> +  humanReadableName: "Text Autosizing"
> +  humanReadableDescription: "Enable text autosizing, which increases text
size so as to be more easily read"
> +  category: internal
> +
> +ForceAutoBehaviorForTextSizeAdjust:
> +  type: bool
> +  defaultValue: false
> +  condition: ENABLE(TEXT_AUTOSIZING)
> +  humanReadableName: "Force text-size-adjust to auto"
> +  humanReadableDescription: "Force -webkit-text-size-adjust to behave like
auto, which means web authors can't opt-out of text autosizing heuristics"
> +  category: internal

I think you should move these down to the  bottom with the other Internal
features.