[webkit-reviews] review requested: [Bug 197291] Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr : [Attachment 368265] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 25 15:01:50 PDT 2019
Ross Kirsling <ross.kirsling at sony.com> has asked for review:
Bug 197291: Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
https://bugs.webkit.org/show_bug.cgi?id=197291
Attachment 368265: Patch
https://bugs.webkit.org/attachment.cgi?id=368265&action=review
--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 368265
--> https://bugs.webkit.org/attachment.cgi?id=368265
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=368265&action=review
> Source/WTF/wtf/text/StringCommon.h:469
> +inline size_t findIgnoringASCIICaseWithoutLength(const char* source, const
char* matchCharacters)
Looking at the other *WithoutLength functions, I wonder if `source` should have
a templated type (i.e. const StringClass&)?
More information about the webkit-reviews
mailing list