[webkit-reviews] review granted: [Bug 197294] [bmalloc] Follow-up and fixing bug after r244481 : [Attachment 368268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 25 14:20:38 PDT 2019

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 197294: [bmalloc] Follow-up and fixing bug after r244481

Attachment 368268: Patch


--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 368268
  --> https://bugs.webkit.org/attachment.cgi?id=368268

View in context: https://bugs.webkit.org/attachment.cgi?id=368268&action=review


> Source/bmalloc/bmalloc/IsoHeapImplInlines.h:234
> +    auto getNewAllocationMode = [&] {

you can also make this cleaner by doing:

- removing all assignments to m_lastSlowPathTime in the lambda
- "auto now = std::chrono::steady_clock::now();" outside the lambda.
- then below, you could do: m_lastSlowPathTime = now;

More information about the webkit-reviews mailing list