[webkit-reviews] review granted: [Bug 196357] [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure : [Attachment 368242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 25 12:58:01 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 196357: [ iOS Sim ] REGRESSION (r242986) Layout Test
storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196357

Attachment 368242: Patch

https://bugs.webkit.org/attachment.cgi?id=368242&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 368242
  --> https://bugs.webkit.org/attachment.cgi?id=368242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368242&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBTransaction.h:149
> +    bool isEventDispatched() const { return m_eventDispatched; }

Let's call this 

    bool didDispatchAbortOrCommit() const { return m_didDispatchAbortOrCommit;
}


More information about the webkit-reviews mailing list