[webkit-reviews] review granted: [Bug 197249] [Win] Add flag to enable version information stamping and disable by default. : [Attachment 368256] PATCH

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 197249: [Win] Add flag to enable version information stamping and disable
by default.
https://bugs.webkit.org/show_bug.cgi?id=197249

Attachment 368256: PATCH

https://bugs.webkit.org/attachment.cgi?id=368256&action=review




--- Comment #9 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 368256
  --> https://bugs.webkit.org/attachment.cgi?id=368256
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=368256&action=review

r=me with one concern.

> Source/cmake/WebKitFeatures.cmake:224
> +    WEBKIT_OPTION_DEFINE(USE_VERSION_STAMPER "Toggle stamping version
information during build" PRIVATE OFF)

If this is Windows-specific then I'm not certain whether we should add it here.

Note that OptionsGTK.cmake defines a bunch of port-specific options near the
top:
https://github.com/WebKit/webkit/blob/master/Source/cmake/OptionsGTK.cmake#L72-
L87

Perhaps we should do similarly for OptionsWin?