[webkit-reviews] review granted: [Bug 197273] DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test : [Attachment 368212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 25 11:23:37 PDT 2019


Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 197273: DumpRenderTree doesn't call Internals::resetToConsistentState()
before the first test
https://bugs.webkit.org/show_bug.cgi?id=197273

Attachment 368212: Patch

https://bugs.webkit.org/attachment.cgi?id=368212&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 368212
  --> https://bugs.webkit.org/attachment.cgi?id=368212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368212&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1887
> +    // in the case that a test using the chrome input field failed, be sure
to clean up for the next test

Please fix to be sentence style.


More information about the webkit-reviews mailing list