[webkit-reviews] review granted: [Bug 197161] Remove DeprecatedOptional : [Attachment 368192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 25 08:59:11 PDT 2019

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197161: Remove DeprecatedOptional

Attachment 368192: Patch


--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 368192
  --> https://bugs.webkit.org/attachment.cgi?id=368192

View in context: https://bugs.webkit.org/attachment.cgi?id=368192&action=review

> Source/JavaScriptCore/ChangeLog:19
> +	   * inspector/InspectorBackendDispatcherCompatibility.cpp: Added.
> +	   (Inspector::BackendDispatcher::reportProtocolError):
> +	   * inspector/InspectorBackendDispatcherCompatibility.h: Added.

I think the contents of InspectorBackendDispatcherCompatibility.h could all be
entirely within InspectorBackendDispatcherCompatibility.cpp; we don’t need two

> +// This symbol must be exported from JavaScriptCore to maintain binary
compatibility with iOS12.

I’d like the other implicit half of this to be explicitly stated. "We can, and
should, remove this entire file once we no longer need binary compatibility
with iOS 12."

More information about the webkit-reviews mailing list