[webkit-reviews] review granted: [Bug 197244] Add SPI callbacks for before and after module execution : [Attachment 368183] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 24 15:17:25 PDT 2019
Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 197244: Add SPI callbacks for before and after module execution
https://bugs.webkit.org/show_bug.cgi?id=197244
Attachment 368183: patch
https://bugs.webkit.org/attachment.cgi?id=368183&action=review
--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 368183
--> https://bugs.webkit.org/attachment.cgi?id=368183
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=368183&action=review
r=me. BTW, this use case is actually why we have moduleLoaderEvaluate hook in
ModuleLoader APIs. WebCore does the almost same thing to tell the inspector
about module evaluation :)
> Source/JavaScriptCore/API/JSAPIGlobalObject.mm:249
> + String moduleKey = key.toWTFString(exec);
> + RETURN_IF_EXCEPTION(scope, { });
In JSContext / JSScript module loading API desing, the key is always URL String
(not Symbol), is my understanding correct? If so, it is fine.
More information about the webkit-reviews
mailing list