[webkit-reviews] review granted: [Bug 197233] [GTK] Back/forward gesture snapshot always times out : [Attachment 368125] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Alexander Mikhaylenko
<exalm7659 at gmail.com>'s request for review:
Bug 197233: [GTK] Back/forward gesture snapshot always times out
https://bugs.webkit.org/show_bug.cgi?id=197233

Attachment 368125: Patch

https://bugs.webkit.org/attachment.cgi?id=368125&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 368125
  --> https://bugs.webkit.org/attachment.cgi?id=368125
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368125&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:207
> +    bool isBackForwardNavigationGestureEnabled { false };

It's a priv struct: let glib zero the memory for us.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1631
> +    WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;

Moved by mistake?