[webkit-reviews] review requested: [Bug 195623] Link prefetch not useful for top-level navigation : [Attachment 368016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 13:21:12 PDT 2019


Rob Buis <rbuis at igalia.com> has asked  for review:
Bug 195623: Link prefetch not useful for top-level navigation
https://bugs.webkit.org/show_bug.cgi?id=195623

Attachment 368016: Patch

https://bugs.webkit.org/attachment.cgi?id=368016&action=review




--- Comment #167 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 368016
  --> https://bugs.webkit.org/attachment.cgi?id=368016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368016&action=review

>> Source/WebKit/NetworkProcess/NetworkProcess.h:560
>> +	PrefetchCache m_prefetchCache;
> 
> This should probably live on the NetworkSession.  We don't want private
browsing to share state with non-private browsing.

Done.

>> Source/WebKit/NetworkProcess/cache/PrefetchCache.h:50
>> +	    RefPtr<WebCore::SharedBuffer> releaseBuffer() { return
buffer.releaseNonNull(); }
> 
> If we're really releasing non null, then this could be a Ref.

Done.

>> LayoutTests/http/tests/contentextensions/prefetch-blocked.html.json:7
>> +		"url-filter": "should-not-load"
> 
> This trigger should have "resource-type": "document"

Done.


More information about the webkit-reviews mailing list