[webkit-reviews] review granted: [Bug 197238] Age out unconverted Ad Click Attributions after one week. : [Attachment 368158] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 197238: Age out unconverted Ad Click Attributions after one week.
https://bugs.webkit.org/show_bug.cgi?id=197238

Attachment 368158: Patch

https://bugs.webkit.org/attachment.cgi?id=368158&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 368158
  --> https://bugs.webkit.org/attachment.cgi?id=368158
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368158&action=review

> Source/WebCore/loader/AdClickAttribution.cpp:99
> +    m_timeOfAdClick = m_timeOfAdClick - maxAge - 1_s;

cannot we use m_timeOfAdClick = {} ? Then the time would be epoch, which I bet
would be considered as expired.