[webkit-reviews] review granted: [Bug 194645] Clean up WKActionSheetAssistant's use of LaunchServices : [Attachment 368101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 10:39:09 PDT 2019


Andy Estes <aestes at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 194645: Clean up WKActionSheetAssistant's use of LaunchServices
https://bugs.webkit.org/show_bug.cgi?id=194645

Attachment 368101: Patch

https://bugs.webkit.org/attachment.cgi?id=368101&action=review




--- Comment #6 from Andy Estes <aestes at apple.com> ---
Comment on attachment 368101
  --> https://bugs.webkit.org/attachment.cgi?id=368101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368101&action=review

> Source/WTF/wtf/Platform.h:1530
>  #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000)
> +#define HAVE_APP_LINKS_WITH_ISENABLED 1
>  #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1
>  #endif

Should this all be in AdditionalFeatureDefines?


More information about the webkit-reviews mailing list