[webkit-reviews] review denied: [Bug 196372] Stop IDB transactions to release locked database files when network process is ready to suspend : [Attachment 368128] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 196372: Stop IDB transactions to release locked database files when network
process is ready to suspend
https://bugs.webkit.org/show_bug.cgi?id=196372

Attachment 368128: Patch

https://bugs.webkit.org/attachment.cgi?id=368128&action=review




--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 368128
  --> https://bugs.webkit.org/attachment.cgi?id=368128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368128&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:36
> +    SetIsIndexedDatabaseHoldingLockedFiles(bool
isIndexedDatabaseHoldingLockedFiles)

I still do not understand why IDB needs its own file locking mechanism and why
it does not rely and the normal SetIsHoldingLockedFiles().