[webkit-reviews] review granted: [Bug 197148] [aarch64] clang Wc++11-narrowing for unsigned char in WebCore/contentextensions : [Attachment 368036] webkit-schar.patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 08:24:53 PDT 2019


Alex Christensen <achristensen at apple.com> has granted wk at unrelenting.technology
<wk at unrelenting.technology>'s request for review:
Bug 197148: [aarch64] clang Wc++11-narrowing for unsigned char in
WebCore/contentextensions
https://bugs.webkit.org/show_bug.cgi?id=197148

Attachment 368036: webkit-schar.patch v2

https://bugs.webkit.org/attachment.cgi?id=368036&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 368036
  --> https://bugs.webkit.org/attachment.cgi?id=368036
webkit-schar.patch v2

See
https://github.com/llvm/llvm-project/blob/master/lldb/source/Utility/ArchSpec.c
pp#L763 for why this kind of thing is necessary :/


More information about the webkit-reviews mailing list