[webkit-reviews] review granted: [Bug 197229] Visited link hash should be computed only once : [Attachment 368122] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 08:17:11 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 197229: Visited link hash should be computed only once

Attachment 368122: patch


--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 368122
  --> https://bugs.webkit.org/attachment.cgi?id=368122

View in context: https://bugs.webkit.org/attachment.cgi?id=368122&action=review

> Source/WebCore/html/HTMLAnchorElement.h:119
> +    // This is computed only once and must not be affected by subsequent URL
> +    mutable Optional<SharedStringHash> m_storedVisitedLinkHash;

Would mutable Optional<const SharedStringHash> work?

More information about the webkit-reviews mailing list