[webkit-reviews] review granted: [Bug 196913] [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled : [Attachment 367536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 03:31:16 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 196913: [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
https://bugs.webkit.org/show_bug.cgi?id=196913

Attachment 367536: Patch

https://bugs.webkit.org/attachment.cgi?id=367536&action=review




--- Comment #12 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 367536
  --> https://bugs.webkit.org/attachment.cgi?id=367536
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367536&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:230
> +	   if (getenv("USE_PLAYBIN3"))

I'd use g_getenv and we're good to go.


More information about the webkit-reviews mailing list