[webkit-reviews] review granted: [Bug 197215] Remove Ad Click Attribution data when removing website data : [Attachment 368076] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 197215: Remove Ad Click Attribution data when removing website data
https://bugs.webkit.org/show_bug.cgi?id=197215

Attachment 368076: Patch

https://bugs.webkit.org/attachment.cgi?id=368076&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 368076
  --> https://bugs.webkit.org/attachment.cgi?id=368076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368076&action=review

> Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:181
> +    m_unconvertedAdClickAttributionMap.removeIf([domain = domain](auto&
keyAndValue) {

domain = domain
should be
&domain

> Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:182
> +	   if (keyAndValue.key.first.registrableDomain == domain ||
keyAndValue.key.second.registrableDomain == domain)

could be written on one line:
return keyAndValue.key.first.registrableDomain == domain ||
keyAndValue.key.second.registrableDomain == domain;

> Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:187
> +    m_convertedAdClickAttributionMap.removeIf([domain =
WTFMove(domain)](auto& keyAndValue) {

ditto, should be &domain.

> Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:188
> +	   if (keyAndValue.key.first.registrableDomain == domain ||
keyAndValue.key.second.registrableDomain == domain)

ditto, could be written on 1 line.