[webkit-reviews] review granted: [Bug 197205] webkitpy: Kill unresponsive worker processes : [Attachment 368049] Patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 197205: webkitpy: Kill unresponsive worker processes
https://bugs.webkit.org/show_bug.cgi?id=197205

Attachment 368049: Patch

https://bugs.webkit.org/attachment.cgi?id=368049&action=review




--- Comment #6 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 368049
  --> https://bugs.webkit.org/attachment.cgi?id=368049
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368049&action=review

> Tools/Scripts/webkitpy/common/message_pool.py:146
> +		   worker.join(timeout=deadline - time.time())

in our chat, you discovered this should probably be  join(max(deadline -
time.time(), 0))
it might be worth seeing what join will do with a negative timeout... maybe it
behaves in an ok way.