[webkit-reviews] review granted: [Bug 197170] [PlayStation] Support running of JSC tests on remote playstation devices : [Attachment 367956] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 197170: [PlayStation] Support running of JSC tests on remote playstation
devices
https://bugs.webkit.org/show_bug.cgi?id=197170

Attachment 367956: Patch

https://bugs.webkit.org/attachment.cgi?id=367956&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 367956
  --> https://bugs.webkit.org/attachment.cgi?id=367956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367956&action=review

> Tools/Scripts/webkitdirs.pm:779
> +    if (isAnyWindows() && !isPlayStation()) {

I wish there were a way to write this without baking in the idea that
isPlayStation implies isAnyWindows but it makes sense to have the bin[64|32]
branch first.