[webkit-reviews] review granted: [Bug 197180] [ews-build] Trigger queues only after uploading the archive : [Attachment 367989] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 22 16:44:28 PDT 2019
Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 197180: [ews-build] Trigger queues only after uploading the archive
https://bugs.webkit.org/show_bug.cgi?id=197180
Attachment 367989: Patch
https://bugs.webkit.org/attachment.cgi?id=367989&action=review
--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 367989
--> https://bugs.webkit.org/attachment.cgi?id=367989
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367989&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:394
> + def propertiesToPassToTriggers(self):
how about renaming this to triggerProperties?
otherwise, lgtm!
More information about the webkit-reviews
mailing list