[webkit-reviews] review denied: [Bug 196991] -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials : [Attachment 367981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 22 14:47:58 PDT 2019


Alex Christensen <achristensen at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 196991: -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]
never returns _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=196991

Attachment 367981: Patch

https://bugs.webkit.org/attachment.cgi?id=367981&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367981
  --> https://bugs.webkit.org/attachment.cgi?id=367981
Patch

Please add a test.  See https://bugs.webkit.org/show_bug.cgi?id=197093 for an
example of a test for doing things with credentials.


More information about the webkit-reviews mailing list