[webkit-reviews] review granted: [Bug 197164] webkitpy auto installer should download packages using `curl` instead of python's urllib. : [Attachment 367967] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dean Johnson
<dean_johnson at apple.com>'s request for review:
Bug 197164: webkitpy auto installer should download packages using `curl`
instead of python's urllib.
https://bugs.webkit.org/show_bug.cgi?id=197164

Attachment 367967: Patch

https://bugs.webkit.org/attachment.cgi?id=367967&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 367967
  --> https://bugs.webkit.org/attachment.cgi?id=367967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367967&action=review

> Tools/ChangeLog:11
> +	   * Scripts/webkitpy/common/system/autoinstall.py:
> +	   (AutoInstaller._download): Use curl to download packages necessary
for webkitpy/thirdparty/autoinstalled
> +	   since Python2's urllib2 module sometimes spews useless error
messages about TLS versions or certificate access
> +	   even if invoking a command to do the same thing with `curl` would
work without issue.

No elegant way to quiet the messages?