[webkit-reviews] review granted: [Bug 197078] WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen : [Attachment 367822] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197078: WKContentRuleLists should have a maximum FileProtection of
CompleteUnlessOpen
https://bugs.webkit.org/show_bug.cgi?id=197078

Attachment 367822: Patch

https://bugs.webkit.org/attachment.cgi?id=367822&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 367822
  --> https://bugs.webkit.org/attachment.cgi?id=367822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367822&action=review

r=me

> Source/WebKit/NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm:39
> +    // FIXME: For the network cache we should either use
makeSafeToUseMemoryMapForPath instead of this
> +    // or we should listen to
UIApplicationProtectedDataWillBecomeUnavailable and unmap files.

Can you address this FIXME in a follow-up patch? Should be pretty
straight-forward. (We probably can't close the Radar until we fix both cases.)