[webkit-reviews] review granted: [Bug 197140] Update text for old EWS submit button : [Attachment 367890] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 197140: Update text for old EWS submit button
https://bugs.webkit.org/show_bug.cgi?id=197140

Attachment 367890: Patch

https://bugs.webkit.org/attachment.cgi?id=367890&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 367890
  --> https://bugs.webkit.org/attachment.cgi?id=367890
Patch

Has there been feedback suggesting this? I’m not sure if old/new is an
important distinction for WebKit developers - what seems important to me is
which tests are triggered by which button. 

It may be ok to treat this temporary state where we have two as transitional,
and not over-optimize it. 

Longer term, this button name should be tweaked to be more clear on two things:

1. It doesn’t need to be pressed if the attachment is a patch for review. 

2. What EWS even is in the first place.