[webkit-reviews] review denied: [Bug 197132] Progress towards resurrecting Mac CMake build : [Attachment 367865] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 19 19:44:04 PDT 2019
Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197132: Progress towards resurrecting Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=197132
Attachment 367865: Patch
https://bugs.webkit.org/attachment.cgi?id=367865&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367865
--> https://bugs.webkit.org/attachment.cgi?id=367865
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367865&action=review
> Source/WebCore/CMakeLists.txt:2041
> + COMMAND ${PERL_EXECUTABLE} ${JavaScriptCore_SCRIPTS_DIR}/xxd.pl
WHLSLStandardLibrary
${WEBCORE_DIR}/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
${WebCore_DERIVED_SOURCES_DIR}/WHLSLStandardLibrary.h
${WebCore_DERIVED_SOURCES_DIR}/WHLSLStandardLibrary.cpp
Something isn't quite right here. It doesn't make WHLSLStandardLibrary.cpp
More information about the webkit-reviews
mailing list