[webkit-reviews] review granted: [Bug 197112] [CMake][Win] Use target oriented design for WebKitLegacy : [Attachment 367847] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 19 17:12:27 PDT 2019

Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 197112: [CMake][Win] Use target oriented design for WebKitLegacy

Attachment 367847: Patch


--- Comment #6 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 367847
  --> https://bugs.webkit.org/attachment.cgi?id=367847

View in context: https://bugs.webkit.org/attachment.cgi?id=367847&action=review

> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:45
>  include_directories(

When we finally convert project to target-oriented design,
include_directories() and similar command should be gone (and banned by

More information about the webkit-reviews mailing list