[webkit-reviews] review denied: [Bug 195623] Link prefetch not useful for top-level navigation : [Attachment 367804] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 19 16:44:25 PDT 2019
Alex Christensen <achristensen at apple.com> has denied review:
Bug 195623: Link prefetch not useful for top-level navigation
https://bugs.webkit.org/show_bug.cgi?id=195623
Attachment 367804: Patch
https://bugs.webkit.org/attachment.cgi?id=367804&action=review
--- Comment #151 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367804
--> https://bugs.webkit.org/attachment.cgi?id=367804
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367804&action=review
> Source/WebCore/loader/ResourceLoadInfo.h:45
> + Prefetch = 0x0400,
This does not need to be added. If I am correct, these "Prefetch" loads are
just Documents, right?
> Source/WebCore/loader/ResourceLoader.cpp:345
> + ASSERT(m_resourceType != ResourceType::Invalid || m_resourceType ==
ResourceType::Prefetch);
This is redundant. If the resource type is equal to Prefetch, then it is also
not equal to Invalid. Why did you add this?
> Source/WebCore/loader/ResourceLoader.cpp:356
> + if (!redirectResponse.isNull() && frameLoader() && m_resourceType !=
ResourceType::Prefetch) {
This adds a way to bypass WKContentRuleLists entirely with prefetch. We do not
want to do this.
More information about the webkit-reviews
mailing list