[webkit-reviews] review granted: [Bug 197108] Disable Ad Click Attribution in ephemeral sessions and make sure conversion requests use an ephemeral, stateless session : [Attachment 367849] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 197108: Disable Ad Click Attribution in ephemeral sessions and make sure
conversion requests use an ephemeral, stateless session
https://bugs.webkit.org/show_bug.cgi?id=197108

Attachment 367849: Patch

https://bugs.webkit.org/attachment.cgi?id=367849&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367849
  --> https://bugs.webkit.org/attachment.cgi?id=367849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367849&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:218
> +	   m_task = [cocoaSession.m_ephemeralStatelessCookielessSession
dataTaskWithRequest:nsRequest];

To lazily initialize m_ephemeralStatelessCookielessSession, just put the call
to initializeEphemeralStatelessCookielessSession before this line.  Then inside
initializeEphemeralStatelessCookielessSession early return if
m_ephemeralStatelessCookielessSession is non null.