[webkit-reviews] review granted: [Bug 195623] Link prefetch not useful for top-level navigation : [Attachment 367804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 19 13:38:41 PDT 2019

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 195623: Link prefetch not useful for top-level navigation

Attachment 367804: Patch


--- Comment #149 from Darin Adler <darin at apple.com> ---
Comment on attachment 367804
  --> https://bugs.webkit.org/attachment.cgi?id=367804

View in context: https://bugs.webkit.org/attachment.cgi?id=367804&action=review

> Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:61
> +	   return std::get<0>(tuple) == sessionID && std::get<1>(tuple) == url;

I think it’s more elegant to write it this way:

    return tuple == std::tie(sessionID, url);

Unless that doesn’t work for some reason?

More information about the webkit-reviews mailing list