[webkit-reviews] review granted: [Bug 197104] Minor PSON release logging improvements : [Attachment 367802] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 19 10:02:55 PDT 2019

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 197104: Minor PSON release logging improvements

Attachment 367802: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 367802
  --> https://bugs.webkit.org/attachment.cgi?id=367802

View in context: https://bugs.webkit.org/attachment.cgi?id=367802&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2874
> +    RELEASE_LOG_IF_ALLOWED(Loading, "continueNavigationInNewProcess: webPID
= %i, pageID = %" PRIu64 ", newProcessPID = %i, hasSuspendedPage = %d",
m_process->processIdentifier(), m_pageID, newProcess->processIdentifier(),

Strange to use both %i and %d when they are synonyms.

More information about the webkit-reviews mailing list