[webkit-reviews] review granted: [Bug 196866] [WinCairo] Non-unified build fails to link Tools : [Attachment 367756] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 196866: [WinCairo] Non-unified build fails to link Tools
https://bugs.webkit.org/show_bug.cgi?id=196866

Attachment 367756: Patch

https://bugs.webkit.org/attachment.cgi?id=367756&action=review




--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 367756
  --> https://bugs.webkit.org/attachment.cgi?id=367756
Patch

I prefer the Object library approach to /WHOLEARCHIVE and --whole-archive
switches.
Looks good to me.

I have some questions.

Do you know the reason why GTK port doesn't have the same issue?

According to the document, use need to use $<TARGET_OBJECTS:WebCore> in order
to use Object Library. Do you know the reason why you don't need it actually?
https://cmake.org/cmake/help/latest/command/add_library.html#object-libraries