[webkit-reviews] review requested: [Bug 174212] [JSC] Add support for instance class fields : [Attachment 367749] Class fields, parser + byte code + test changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 13:48:55 PDT 2019


Caio Lima <ticaiolima at gmail.com> has asked  for review:
Bug 174212: [JSC] Add support for instance class fields
https://bugs.webkit.org/show_bug.cgi?id=174212

Attachment 367749: Class fields, parser + byte code + test changes

https://bugs.webkit.org/attachment.cgi?id=367749&action=review




--- Comment #85 from Caio Lima <ticaiolima at gmail.com> ---
Created attachment 367749

  --> https://bugs.webkit.org/attachment.cgi?id=367749&action=review

Class fields, parser + byte code + test changes

I'm sending this because Xan is on holidays, but most of the Patch is an effort
from Xan and Caitp, with some fixes that I've made.

There is a case where the implementation is not passing the test (see below),
but we think it is ready for another batch of review.

```
{
  class C {
    x = Object.freeze(this);
    c = 42;
  }
  assertThrows(() => { new C; }, TypeError);
}
```


More information about the webkit-reviews mailing list