[webkit-reviews] review denied: [Bug 197046] AX: Improve the exception message in Tools/Scripts/webkitpy/common/system/autoinstall.py (line 360) : [Attachment 367717] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 09:21:23 PDT 2019


Alexey Proskuryakov <ap at webkit.org> has denied yevseytsev
<yevseytsev at gmail.com>'s request for review:
Bug 197046: AX: Improve the exception message in
Tools/Scripts/webkitpy/common/system/autoinstall.py (line 360)
https://bugs.webkit.org/show_bug.cgi?id=197046

Attachment 367717: Patch

https://bugs.webkit.org/attachment.cgi?id=367717&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 367717
  --> https://bugs.webkit.org/attachment.cgi?id=367717
Patch

There is something wrong with this patch, as it's half a megabyte in size, and
touches lots of ANGLE files. Perhaps some newline format change made tools
think that all files were rewritten?


More information about the webkit-reviews mailing list