[webkit-reviews] review granted: [Bug 197004] [Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html : [Attachment 367722] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 197004: [Pointer Events WPT] Unskip
imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_f
or_disconnected_node.html
https://bugs.webkit.org/show_bug.cgi?id=197004

Attachment 367722: Patch

https://bugs.webkit.org/attachment.cgi?id=367722&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 367722
  --> https://bugs.webkit.org/attachment.cgi?id=367722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367722&action=review

> Source/WebCore/page/PointerCaptureController.cpp:133
> +    for (auto& keyAndValue : m_activePointerIdsToCapturingData) {

I suppose this map is mostly empty/has very few items?

> Source/WebCore/page/PointerCaptureController.cpp:147
> +	   return;
> +    }

I feel for loops read better if the bail out case is a branch, not the body of
the loop.