[webkit-reviews] review granted: [Bug 197016] Rename "supported-color-schemes" to "color-schemes" : [Attachment 367677] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 197016: Rename "supported-color-schemes" to "color-schemes"
https://bugs.webkit.org/show_bug.cgi?id=197016

Attachment 367677: Patch

https://bugs.webkit.org/attachment.cgi?id=367677&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 367677
  --> https://bugs.webkit.org/attachment.cgi?id=367677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367677&action=review

> Source/WebCore/ChangeLog:22
> +	   Changed `supported-color-schemes` to `color-schemes` to follow the
spec changes
> +	   being tracked by: https://github.com/w3c/csswg-drafts/issues/3807
> +
> +	   The old `supported-color-schemes` is now an alias of `color-schemes`
for compatability.

This should go above the "Tests" section.

> Source/WebCore/css/CSSProperties.json:5980
> +		   "aliases": [
> +		       "supported-color-schemes"
> +		   ],
> +		   "converter": "ColorSchemes",

Do we have "status" text that says that it's in progress?