[webkit-reviews] review granted: [Bug 196996] Web Inspector: Extension scripts with parse errors do not show up in Web Inspector : [Attachment 367659] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 196996: Web Inspector: Extension scripts with parse errors do not show up
in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=196996

Attachment 367659: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=367659&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 367659
  --> https://bugs.webkit.org/attachment.cgi?id=367659
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=367659&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:20
> +	   Local scripts provide a null id and id is not required below.

Along these lines, I'd remove the `|| null` from `this._range = range || null;`
since it's asserted that it's a `WI.TextRange`.