[webkit-reviews] review denied: [Bug 196996] Web Inspector: Extension scripts with parse errors do not show up in Web Inspector : [Attachment 367597] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 17 11:50:53 PDT 2019


Devin Rousso <drousso at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 196996: Web Inspector: Extension scripts with parse errors do not show up
in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=196996

Attachment 367597: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=367597&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 367597
  --> https://bugs.webkit.org/attachment.cgi?id=367597
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=367597&action=review

r-, missing ChangeLog :(

> Source/WebInspectorUI/UserInterface/Models/Script.js:-32
> -	   console.assert(id);

Why was this removed?


More information about the webkit-reviews mailing list