[webkit-reviews] review granted: [Bug 197012] REGRESSION (r243926): [iOS] Release assertion when computing editor state during an overflow scroll triggered by layout : [Attachment 367635] Fixes the bug

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 197012: REGRESSION (r243926): [iOS] Release assertion when computing editor
state during an overflow scroll triggered by layout
https://bugs.webkit.org/show_bug.cgi?id=197012

Attachment 367635: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=367635&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 367635
  --> https://bugs.webkit.org/attachment.cgi?id=367635
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=367635&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5295
>  void WebPage::didChangeSelection()
> +{
> +   
didChangeSelectionOrOverflowScrollPosition(EditorStateUpdateScheduling::Immedia
te);
> +}

Don't we run the risk that callers of this will trigger the same release
assert?