[webkit-reviews] review granted: [Bug 182512] [CMake] Make WebCore headers copies : [Attachment 367601] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 17 09:01:35 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 182512: [CMake] Make WebCore headers copies
https://bugs.webkit.org/show_bug.cgi?id=182512
Attachment 367601: Patch
https://bugs.webkit.org/attachment.cgi?id=367601&action=review
--- Comment #105 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367601
--> https://bugs.webkit.org/attachment.cgi?id=367601
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367601&action=review
Looks good to me
> Source/WebCore/Headers.cmake:1211
> + plugins/npfunctions.h
It looks like the AppleWin build can't find this file from DumpRenderTree.
More information about the webkit-reviews
mailing list