[webkit-reviews] review denied: [Bug 182512] [CMake] Make WebCore headers copies : [Attachment 367576] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 182512: [CMake] Make WebCore headers copies
https://bugs.webkit.org/show_bug.cgi?id=182512

Attachment 367576: Patch

https://bugs.webkit.org/attachment.cgi?id=367576&action=review




--- Comment #99 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 367576
  --> https://bugs.webkit.org/attachment.cgi?id=367576
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367576&action=review

> Source/WebCore/PlatformAppleWin.cmake:58
> +list(APPEND WebCore_PRIVATE_FORWARDING_HEADERS

WebCore_PRIVATE_FORWARDING_HEADERS should be WebCore_PRIVATE_FRAMEWORK_HEADERS.
This is the reason for the AppleWin EWS failure.

> Source/WebCore/PlatformAppleWin.cmake:73
> +    list(APPEND WebCore_PRIVATE_INCLUDE_DIRECTORIES

Ditto.