[webkit-reviews] review requested: [Bug 196996] Web Inspector: Extension scripts with parse errors do not show up in Web Inspector : [Attachment 367597] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 196996: Web Inspector: Extension scripts with parse errors do not show up
in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=196996

Attachment 367597: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=367597&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 367597

  --> https://bugs.webkit.org/attachment.cgi?id=367597&action=review

[PATCH] Proposed Fix

For now this is useful for extension which I don't know how to test...

The only thing this might eventually be useful for would be anonymous evals:

    setTimeout(() => {
	eval("console.log(1) }}}");
    });

Which after the above still won't have a URL so the later parse error won't
handle this.

---

We could create a console message error here if `url` is null and ignore the
`Console.messageAdded` in that case. This seems pretty edge casey at the
moment.