[webkit-reviews] review granted: [Bug 196980] Link clicks in PDFs shouldn't send referrer headers : [Attachment 367563] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 13:58:18 PDT 2019


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 196980: Link clicks in PDFs shouldn't send referrer headers
https://bugs.webkit.org/show_bug.cgi?id=196980

Attachment 367563: Patch

https://bugs.webkit.org/attachment.cgi?id=367563&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 367563
  --> https://bugs.webkit.org/attachment.cgi?id=367563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367563&action=review

> LayoutTests/http/tests/security/pdf-referrer.html:4
> +if (window.testRunner) { 

Please make it more clear how this checks for the referrer

> LayoutTests/http/tests/security/pdf-referrer.html:13
> +	testRunner.notifyDone();

weird extra tab


More information about the webkit-reviews mailing list